Fix span metadata when inserting table rows and columns - #3453
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Julia Roldi (juliaroldi)
marked this pull request as ready for review
September 1, 2026 14:02
Jiuqing Song (JiuqingSong)
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update
insertTableColumnandinsertTableRowso newly inserted cells do not inherit span metadata in the insertion direction. Inserted columns now clearspanLeft, and inserted rows clearspanAbove, preventing the new cells from being treated as continuations of existing merged cells.Update the table insertion unit tests to cover inserting above, below, and to the right of cells with span metadata.
Before:
After:
How to test
yarn test:fast --testPathPattern="insertTable(Column|Row)Test".