fix(render): remove seams between color blocks - #189
Merged
Conversation
cpendery (cpendery)
marked this pull request as ready for review
August 27, 2026 18:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fill_antialiased_rectandfill_pixel_recthelpers instead of the ambiguous regular/crisp rectangle distinctionValidation
cargo clippy -p tui-test-rs --all-targets --all-features -- -D warningscargo test -p tui-test-rs --all-features -- --test-threads=1bash scripts/regenerate-static-media.shcargo test -p tui-test-rs --all-features single_frame_gif_and_png_renders_match_snapshotsBefore and after
Both captures use the same terminal content and
--zoom 0.625. The first two rows are equal-width 30-cell comparisons with the cursor hidden. The third row deliberately shows the cursor after a 29-cell green run, isolating cursor alignment instead of accidentally appending it to the color comparison.The solid bar drops from 30 off-color seam pixels to 0. At the cursor boundary, the before image contains a blended transition pixel; the after image ends the green run and starts the full cursor cell on one shared pixel edge.