fix(render): clip symbols to terminal cells - #192
Closed
cpendery (cpendery) wants to merge 3 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo clippy -p tui-test-rs --all-targets --all-features -- -D warningscargo clippy -p tui-test-rs --all-targets --no-default-features -- -D warningscargo test -p tui-test-rs --all-features -- --test-threads=1bash scripts/regenerate-static-media.sh(all generated static timelines were pixel-identical, so timing-only churn was discarded)Before and after
The images are 4x nearest-neighbor crops of the same deterministic snapshot. On
main, the鈻堚枔鈻掆枒row begins five source pixels inside the Powerline row and antialiased symbol pixels can escape neighboring cells. Afterward, symbols stop at the shared snapped edge, and鈻堚枔鈻掆枒each fill the complete cell like the web rendering. The regression measured 200 gray bleed pixels before and 0 after and requires every semantic full-cell glyph to touch all four boundaries.