Route package installs through Microsoft feed proxies by bschnurr · Pull Request #600 · microsoft/vscode-flake8

Bill Schnurr (bschnurr) · 2026-10-16T19:12:42Z

Summary

Port the package-feed migration from microsoft/vscode-isort#773 and microsoft/vscode-isort#775 to vscode-flake8.

Route PR, push, and CodeQL package installation through Microsoft's npm and PyPI proxies.
Remove redundant NPM_CONFIG_REGISTRY from PR/push workflows that install through npm run ci:msft; keep PIP_INDEX_URL and retain registry settings for CodeQL autobuild and Azure template consumers.
Use npm run ci:msft in shared lint/VSIX actions and applicable test jobs, preserving package caching and the VSIX offline-cache preference.
Route DevDiv stable/prerelease builds through the same proxies while preserving release triggers, approval gates, signing, and publishing behavior.
Add public/Microsoft local setup commands, dependency-free regression tests, optional local lockfile-normalization hooks, and contributor documentation.

Ecosystem	Microsoft endpoint
npm	`https://packagefeedproxy.microsoft.io/npm/`
Python	`https://packagefeedproxy.microsoft.io/pypi/simple/`

Repository-specific adaptation

Initialize and build the existing pinned shared-LSP package. Rewrite both expected npm lockfiles before installation while retaining the existing postinstall behavior, test entry point, and submodule revision.

Preserved behavior and boundaries

Dependabot remains on public registries with its existing ecosystems, grouping, schedules, cooldowns, ignores, and limits unchanged.
Committed lockfiles retain public npm URLs for known public-package mirrors. Local proxy rewrites are not committed.
Dependency versions, integrity hashes, submodule revisions, and application behavior are unchanged.
Legacy Azure stable, prerelease, and validation pipeline files are unchanged.
Hooks are opt-in local Git hooks; GitHub and Dependabot do not execute them, and no workflow writes repair commits to PR branches.
No changes to the shared pylance-eng templates are required.

Verification

npm run test:setup: 39 passing tests, including Windows/Linux setup orchestration, rewrite/error handling, integrity preservation, and real temporary-repository hook tests.
npm run lint
npm run format-check
npm run compile-tests
Executable parsed-YAML comparisons against the recorded base verify proxy settings, install entry points, Python step overrides, and unchanged release gates, workflow matrices, cache settings, legacy pipelines, and Dependabot configuration.
npm run ci:msft and standalone rewrite commands exercised locally; uncached npm and Python proxy downloads succeeded.

Hosted GitHub/Azure execution has not been claimed as verified by these local checks. This PR is intentionally a draft.

Port vscode-isort setup, lockfile normalization, GitHub CI, and DevDiv release feed routing while preserving public Dependabot registries and legacy Azure pipeline definitions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e2972852-17e2-4e68-81e8-db73c74bfe25

Let ci:msft explicitly select the npm proxy in PR and push workflows. Retain the Python index and registry configuration for CodeQL/Azure consumers, and add regression coverage and documentation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e2972852-17e2-4e68-81e8-db73c74bfe25

Heejae Chang (heejaechang) · 2026-10-16T22:10:11Z

🔒 Automated review in progress — Heejae Chang (@heejaechang) is auto-reviewing this PR.

Heejae Chang (heejaechang) · 2026-10-16T23:07:42Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-16T23:21:32Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-16T23:34:57Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-16T23:53:20Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-17T00:07:51Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-17T00:25:40Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-17T00:42:26Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-17T00:51:13Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-17T01:05:23Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-17T01:17:45Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-17T01:34:16Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-17T01:47:57Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-17T02:02:52Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-17T02:16:56Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-17T02:30:30Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-17T02:54:53Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-17T03:04:55Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-17T03:12:55Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-17T03:25:55Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-17T03:34:30Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-17T03:52:44Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-17T04:08:31Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-17T04:18:30Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-17T04:32:59Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T06:37:03Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T06:49:47Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T07:03:20Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T07:17:04Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T07:31:18Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T07:45:43Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T07:59:19Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T08:13:42Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T08:27:50Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T08:52:59Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T09:03:09Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T09:16:04Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T09:32:40Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T09:46:44Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T10:05:24Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T10:18:40Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T10:32:13Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T10:45:42Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T10:59:07Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T11:07:32Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T11:25:08Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T11:33:52Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T11:51:39Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T12:04:44Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-18T12:18:21Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-19T05:51:03Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Heejae Chang (heejaechang) · 2026-10-19T19:31:06Z

+        throw new Error('An existing pre-commit hook is installed. Integrate the normalizer into your hook manually.');
+    }
+    chmodSync(path.join(cwd, '.githooks', 'pre-commit'), 0o755);
+    git(['config', '--local', 'core.hooksPath', '.githooks']);


Issue · Please address or respond

📍 build/setup-hooks.js:20
Setting core.hooksPath redirects every Git hook, but this guard checks only pre-commit; the reproduced installation silently disabled an existing executable pre-push guard. Refuse installation whenever any active hook would be displaced, and direct contributors to integrate the normalizer into their existing configuration.

[verified]

Heejae Chang (heejaechang) · 2026-10-19T19:31:25Z

+            const versionCheck = calls[expected.length];
+            assert.equal(versionCheck.command, python);
+            assert.match(versionCheck.args[1], /sys.version_info < \(3, 10\)/);
+            expected.push([python, versionCheck.args, root]);


Warning · Non-blocking recommendation

📍 build/setup.test.js:74
The substring assertion followed by copying versionCheck.args into expected makes the full comparison accept unchecked command arguments, violating docs/pylancewiki/review/tests-no-partial-asserts.md. Define the complete expected ['-c', '<version-check script>'] arguments independently and compare them exactly; the Rules reviewer confirms no dynamic-output exception applies.

[verified]

Heejae Chang (heejaechang) · 2026-10-19T19:31:56Z

Result: 🔴 could-not-verify

Verification details

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: Could not prepare offline npm dependencies: Unsupported registry tarball override for '@vscode/python-environments@1.0.0'.

Test runs: none recorded.

Bill Schnurr (bschnurr) added the debt label Oct 16, 2026

Bill Schnurr (bschnurr) marked this pull request as ready for review October 16, 2026 22:05

Heejae Chang (heejaechang) added the review-auto:changes-requested Automated review: posted blocking findings to address. label Oct 16, 2026

Eduardo Villalpando Mello (edvilme) approved these changes Oct 19, 2026

View reviewed changes

Heejae Chang (heejaechang) reviewed Oct 19, 2026

View reviewed changes

Conversation

Bill Schnurr (bschnurr) commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Repository-specific adaptation

Preserved behavior and boundaries

Verification

Uh oh!

Heejae Chang (heejaechang) commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Heejae Chang (heejaechang) commented Oct 16, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 16, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 16, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 16, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 17, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 17, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 17, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 17, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 17, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 17, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 17, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 17, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 17, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 17, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 17, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 17, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 17, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 17, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 17, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 17, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 17, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 17, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 17, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 17, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 18, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 18, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 18, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 18, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 18, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 18, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 18, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 18, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 18, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 18, 2026

Uh oh!

Heejae Chang (heejaechang) commented Oct 18, 2026

Bill Schnurr (bschnurr) commented Oct 16, 2026 •

edited

Loading

Heejae Chang (heejaechang) commented Oct 16, 2026 •

edited

Loading