Repository navigation
sessions: use checkout icon in new-session isolation picker - #345214
Merged
Megan Rogge (meganrogge) merged 3 commits intoOct 30, 2026
Merged
Conversation
Adopt Codicons 0.0.46-49 for desktop and web and use git-branch-checkout for the Branch option and selected trigger. Preserve labels and cover the menu icons and decorative trigger accessibility in the composer regression test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dirk Bäumer (dbaeumer)
previously approved these changes
Oct 30, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new-session composer still uses the old folder icon for folder/workspace isolation, leaving the icon update incomplete and needing regression coverage for that picker.
1 open issue
1 file not reviewed
remote/web/package-lock.json: Generated file
What changed in this PR
This PR introduces the checkout icon for the Agents window’s Branch isolation option. The current implementation updates the nested-session composer; the main new-session picker remains unchanged.
Changes:
- Registers
git-branch-checkoutand uses it in the nested composer’s isolation picker. - Updates desktop and web Codicons dependencies to
0.0.46-49. - Extends regression assertions for menu icons, selected-trigger icons, and decorative accessibility attributes.
| File | Description |
|---|---|
src/vs/sessions/contrib/chat/test/browser/nestedChatComposer.test.ts |
Adds isolation icon and accessibility assertions. |
src/vs/sessions/contrib/chat/browser/isolationPicker.ts |
Replaces the Branch folder icon with the checkout icon. |
src/vs/base/common/codicons.ts |
Registers the checkout glyph at U+ECFB. |
remote/web/package.json |
Updates the web Codicons dependency. |
remote/web/package-lock.json |
Locks the updated web Codicons package. |
package.json |
Updates the desktop Codicons dependency. |
package-lock.json |
Locks the updated desktop Codicons package. |
Review effort: Balanced
Cover the main new-session composer as well as the shared nested-session picker, including Copilot workspace targets and selected trigger icons. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Cherry Wang (chryw)
previously approved these changes
Oct 30, 2026
Contributor
Screenshot ChangesBase: Changed (3)
|
| Before | After |
|---|---|
 |
 |
sessions/chat/isolationPicker/agentHostSessionConfigPicker/Branch/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/isolationPicker/agentHostSessionConfigPicker/DevContainer/Light
| Before | After |
|---|---|
 |
 |
Allow one microsecond of error when reconstructing frame gaps from browser-rounded animation durations. Preserve the 40 ms frame limit and all production animation behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ulugbek Abdullaev (ulugbekna)
approved these changes
Oct 30, 2026
Megan Rogge (meganrogge)
deleted the
agents/use-codicons-in-new-session-picker
branch
October 30, 2026 18:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #343929
Uses the new
git-branch-checkouticon from microsoft/vscode-codicons#541 for the Branch option in the new-session composer's Branch/New Worktree picker, including the selected trigger, across both the main Agent Host composer (including Copilot workspace targets) and the shared nested-session composer. New Worktree keeps its existing icon. Labels, keyboard behavior, and screen-reader descriptions are unchanged; the trigger icon remains decorative.Updates desktop and web to the now-published Codicons
0.0.46-49. The official prerelease pipeline completed successfully: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=491288. Verified the package's generated TypeScript, CSS, and font-derived CSV contain the glyph with codepoint U+ECFB.Validation
npm run build-fast -- --client-only— passed.npm run eslint -- src/vs/base/common/codicons.ts src/vs/sessions/contrib/chat/browser/isolationPicker.ts src/vs/sessions/contrib/chat/test/browser/nestedChatComposer.test.ts— passed../scripts/test.sh --run src/vs/sessions/contrib/providers/agentHost/test/browser/agentHost/agentHostSessionConfigPicker.test.ts --run src/vs/sessions/contrib/chat/test/browser/nestedChatComposer.test.ts --reporter dot— 100 passed. Native dependencies were rebuilt for the live launch; the final run has no missing-native-module warning.npm run eslint -- src/vs/sessions/contrib/providers/agentHost/browser/agentHostSessionConfigPicker.ts src/vs/sessions/contrib/providers/agentHost/test/browser/agentHost/agentHostSessionConfigPicker.test.ts— passed.npm run hygiene— passed (14,180 files).git diff --check— passed.npm install --prefix remote/web --package-lock-only --ignore-scripts --no-audit --no-fund --registry=https://registry.npmjs.org --min-release-age-exclude=@vscode/codicons— passed. The one-command exception is limited to this verified first-party prerelease; no npm configuration changes.Manual testing
Open the Agents window, choose a Git repository in the new-session composer, and open the Branch/New Worktree picker. Check that Branch uses the checkout icon in the menu and selected trigger, while New Worktree keeps its worktree icon. The shared nested-session composer is covered by the regression test.
Browser CI follow-up
The macOS WebKit job exposed an existing confetti test precision issue, also reproduced locally with test and implementation identical to main. WebKit rounds animation durations to microseconds, producing reconstructed frame gaps such as 40.000013 ms. With maintainer approval, this PR includes a test-only one-microsecond tolerance; the 40 ms frame limit and production animation behavior are unchanged.
npm run build-fast -- --client-only— passed after the test fix.npm run test-browser-no-install -- --browser webkit --browser chromium --browser firefox --run src/vs/base/test/browser/ui/animations/animations.test.ts --reporter dot— passed: 8 tests per browser, 24 total.npm run eslint -- src/vs/base/test/browser/ui/animations/animations.test.ts— passed.git diff --check— passed.