Skip to content

animations: allow WebKit's microsecond duration rounding in the confetti timing test #345220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bryan Chen (bryanchen-d) wants to merge 1 commit into from
+3 −1
Closed

animations: allow WebKit's microsecond duration rounding in the confetti timing test #345220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/vs/base/test/browser/ui/animations/animations.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,15 @@ suite('Animations', () => {
const effect = particle.getAnimations()[0]?.effect as KeyframeEffect | undefined;
const duration = effect?.getTiming().duration;
const keyframes = effect?.getKeyframes();
// WebKit reports the duration rounded to whole microseconds, while the offsets were computed from the
// unrounded duration, so a 40ms step can read as up to 0.001ms longer.
return typeof duration === 'number'
&& duration >= 1150
&& duration < 1510
&& keyframes !== undefined
&& keyframes.length >= 30
&& keyframes.every((keyframe, index) =>
keyframe.easing === 'steps(1)' && (index === 0 || (keyframe.computedOffset - keyframes[index - 1].computedOffset) * duration <= 40 + 1e-10));
keyframe.easing === 'steps(1)' && (index === 0 || (keyframe.computedOffset - keyframes[index - 1].computedOffset) * duration <= 40 + 1e-3));
}),
allParticlesHaveShortFalls: particles.every(particle => {
const keyframes = (particle.getAnimations()[0]?.effect as KeyframeEffect | undefined)?.getKeyframes() ?? [];
Expand Down
Loading