Skip to content

fix: Page for processor health only from the processor - #253

Draft
scotwells wants to merge 1 commit into
mainfrom
fix/scope-processor-alerts-to-processor
Draft

scotwells wants to merge 1 commit into
mainfrom
fix/scope-processor-alerts-to-processor

Conversation

@scotwells

Copy link
Copy Markdown
Contributor

Summary

The processor's NATS-disconnect and empty-policy alerts fire for any pod that exposes those gauges, and the edge event exporter exposes both at zero because it runs the same binary.

In staging this pages a critical alert on both edge labs while the processor is healthy.

Both rules now select only the processor's scrape job, the same selector the processor dashboards and the exporter's own alerts already use.

Test plan

  • A zero gauge from the exporter raises neither alert, and a zero gauge from the processor still raises both (checked with a rule unit test against the old and new rules)
  • After this reaches staging, the two alerts clear on both edge labs

Fixes #252

The processor's NATS-connection and active-policy gauges are registered
in the shared metrics registry of the single activity binary, so every
subcommand serves them. The edge event exporter never sets them and
reports both at zero, so once the edge exporter is scraped it raises a
critical ActivityProcessorNATSDisconnected and an
ActivityProcessorNoPolicies warning against a healthy system.

Key changes:
- Select job="activity-processor" in both rules, matching the processor
  dashboards and the exporter rules that already select their own job
- Leave the rate-based processor rules alone: an idle zero counter
  cannot satisfy them

Changing an expression resets the rule's alert state, so an alert that
is firing when this deploys waits out its "for" again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Processor alerts page for the edge event exporter

1 participant