Repository navigation
Route activity policy failures to their owners - #255
Merged
Merged
Conversation
This was referenced Sep 28, 2026
scotwells
marked this pull request as ready for review
September 28, 2026 19:02
ecv
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an activity policy fails, customers can see gaps in their resource timelines. Route those failures to the team that owns the policy so the right team can investigate and restore missing activity entries, including events already queued for retry.
Set ownership on the ActivityPolicy resource's
metadata.labels, for example:meta.datumapis.com/servicebecomes the alert'sservicelabel;meta.datumapis.com/teambecomes itsteamlabel. Existing Alertmanager routes sendservice=network-servicesto Deliver;team=deliveryrecords the policy's owning team. Setting the team label alone does not create a route.Policies without an owner still alert: a missing service stays unset, a missing team falls back to
sre, and missing ownership metrics do not suppress failures. Ownership changes also apply to existing retry failures.Validated processor tests and ten alert-rule scenarios covering ownership changes, missing metadata, replicas, cluster isolation, and scrape-label collisions; CI is green.
Roll out with https://github.com/datum-cloud/infra/pull/6325 and the policy labels in datum-cloud/network-services-operator#515 and datum-cloud/dns-operator#192. Include this change in staging's federated-events branch before deployment.
Related to https://github.com/datum-cloud/infra/issues/6019.