Skip to content

feat: Route fraud alerts to their owning team - #51

Merged
ecv merged 1 commit into
mainfrom
feat/alert-ownership-labels
Aug 12, 2026
Merged

ecv merged 1 commit into
mainfrom
feat/alert-ownership-labels

Conversation

@ecv

@ecv ecv commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Alerts from this service carried a severity and nothing else, so a page arrived in one shared channel with no indication of who owns it. Every alert rule now declares its owning service and team, so alert routing can send the page to the team that owns fraud and attribute it to them instead of leaving triage to whoever notices first. Severities, expressions, thresholds, and durations are untouched, so what fires and when does not change.

The two values match the ownership table currently under review upstream.

Test plan

  • Rendered alert rules carry both ownership labels on all seven alerts
  • Expressions, thresholds, severities, and annotations are unchanged
  • A firing alert routes to the owning team rather than the shared channel

Related to datum-cloud/infra#3983

Every fraud alert now carries service and team labels alongside severity,
so Alertmanager can route and attribute a page to the team that owns this
service instead of dropping it into one shared channel.

Key changes:
- Add service: fraud and team: platform to all seven alert rules
- Leave expressions, thresholds, durations, and annotations untouched

The label values match the ownership table under ratification in
datum-cloud/infra#3987.
@ecv
ecv marked this pull request as ready for review August 12, 2026 14:34
@ecv
ecv requested a review from scotwells August 12, 2026 14:34
@ecv
ecv enabled auto-merge August 12, 2026 15:01
@ecv
ecv requested review from 0xmc and slindseysr August 12, 2026 15:09
@ecv
ecv merged commit e6a5749 into main Aug 12, 2026
9 checks passed
@ecv
ecv deleted the feat/alert-ownership-labels branch August 12, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants