Conversation
A fabric identity is claimed once per network and retained forever, because reissuing one would merge a new network into a dead one's routes. A project's claim count therefore only rises, and the platform project holding the tenant address pools carries a claim for every network in the environment rather than its own. The old default of 100 was sized for a project's own claims. Production reached 65 of it in seven days at a trailing rate of 21 a day, and reaching 100 fails every address allocation for every tenant, not just the project that crossed the line. Key changes: - Raise the IPClaim default to 10000 and the IPPool default to 2500 - Raise both ceilings so an operator can still grant above the default - Record why the count only rises, so the next person sizing this knows
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A network's fabric identity is claimed once and kept forever, so the platform project holding the tenant address pools accrues a claim for every network in the environment and never releases one.
The default of 100 was sized for a project's own claims, production reached 65 of it in seven days, and hitting 100 refuses every address allocation for every tenant.
This raises the claim default to 10000 and the pool default to 2500, and lifts both ceilings so an operator can still grant above the default.
Important
Production runs on a hand-raised grant of 500 today, which should come out once this default reaches it.
Test plan