Skip to content

Fix bias - #7

Draft
muursh wants to merge 4 commits into
mainfrom
fix_bias
Draft

muursh wants to merge 4 commits into
mainfrom
fix_bias

Conversation

@muursh

@muursh muursh commented Feb 23, 2023

Copy link
Copy Markdown

Added a nonce when scaling up to help avoid bias. For example scaling the value 77 from the original range 0-100 to the new range 0-255 would have always given 196. 78 would have given 198 and 76 193. The value 194 was impossible with an output. With the addition of this nonce the value 194 is now possible (for several input values). We use a pseudorandom float as the nonce which itself has a pseudorandom scale applied. There is still an issue where the original range is much less than 255. For example scaling from an original range of 40 to a range of 255 will still result in slight bias. Further work is required to fix this for any input. On the assumption we use this library to scale down (which is always the safest behaviour) or to scale up from a range of at least 100 this fix is sufficient.

Tests updated to reflect the new nonce meaning the tests are somewhat less deterministic.

@muursh
muursh requested a review from renie February 23, 2023 10:50
@renie
renie marked this pull request as draft August 31, 2023 11:37
@owlsua owlsua added the enhancement New feature or request label Aug 31, 2023
@owlsua
owlsua self-requested a review August 31, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants