Conversation
… life so much easier than rebasing :)
renie
marked this pull request as draft
August 31, 2023 11:37
owlsua
self-requested a review
August 31, 2023 11:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a nonce when scaling up to help avoid bias. For example scaling the value 77 from the original range 0-100 to the new range 0-255 would have always given 196. 78 would have given 198 and 76 193. The value 194 was impossible with an output. With the addition of this nonce the value 194 is now possible (for several input values). We use a pseudorandom float as the nonce which itself has a pseudorandom scale applied. There is still an issue where the original range is much less than 255. For example scaling from an original range of 40 to a range of 255 will still result in slight bias. Further work is required to fix this for any input. On the assumption we use this library to scale down (which is always the safest behaviour) or to scale up from a range of at least 100 this fix is sufficient.
Tests updated to reflect the new nonce meaning the tests are somewhat less deterministic.