Repository navigation
feat(author): the skill no longer sends a chat with its text alone to the skill's page - #197
Merged
Merged
Conversation
… the skill's page The owner dropped reading the skill by its link as a way to give it to a chat (missing-elements.github.io#42): Claude and ChatGPT take it as a zip, Grok takes Claude's. SKILL.md's two "with this text alone" passages go; step 3 still takes the build tool's and the bundles' addresses from the page, which stays for installed copies. design/author.md renames the rule to "The skill is installed, and its page lists what step 3 fetches" and records the Haiku runs, Grok's two-file build and ChatGPT's download tool, which saved none of eleven files on the owner's account. Both READMEs point to the install step instead of the page.
Contributor
There was a problem hiding this comment.
No issues found across 4 files
Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more
View guided diff | Turn on auto-fix | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #196.
What changes
SKILL.md: the two "with this text alone" passages are removed. One was in the opening and sent a chat to/h5p/skill/first. The other was in step 2 and sent it there for a type's file. Step 3 still takes the build tool's and the bundles' addresses from that page, which the site keeps serving.design/author.md: the rule A chat with the skill's text alone takes every address from the skill's page becomes The skill is installed, and its page lists what step 3 fetches. Its history stays, and it records why the passages went and what was measured.design/author.md: Wherenpxcannot install, a page builds records that ChatGPT's own download tool saved nothing on the owner's account. A bundle per content type says that Grok's sandbox fetched a bundle and ChatGPT's did not.README.mdandpackages/author/README.md: they point to the install step atmissing-elements.github.io/h5p/create-with-ai/#installinstead of offering the skill as a link.Measured on Haiku
Without the skill installed. The user's message gave the skill page's address, as the site's old prompt did. The web tool opened only addresses seen whole, and npm was cut off. Three runs per text:
The passages cost nothing here: the page itself says to read
SKILL.mdfirst, and it lists every address.out/.npx @missing-elements/h5p-verify@latest … --previewas an optional check "on a computer with npm".With the skill installed, npm cut off and no web tool, this text only, 2 runs: both handed over the build page's link and the source file. One run dropped two characters of the link while writing its reply, the way ChatGPT does. That is the first time on Haiku, and the source file still builds, which is what 0.9.7 added it for.
Checked
pnpm --filter @missing-elements/h5p-author test:unit: 183 tests pass.typecheckpasses.sync:skillchanges nothing.It reaches users with the next author release and the site's pin bump after it.
Summary by cubic
The
h5p-authorskill no longer tells a chat that has only its text to open/h5p/skill/first for addresses.SKILL.mddrops both "with this text alone" passages, and step 3 still fetches the build tool and bundles from that page, which stays for installed copies.design/author.mdrenames the rule and records measurements: Grok fetched the bundle from the page, while ChatGPT's download tool saved none of eleven files, so the page stays the route there.README.mdandpackages/author/README.mdnow point to the install step atcreate-with-ai/#installinstead of offering the skill as a link.Written for commit 4948c47. Summary will update on new commits.