Repository navigation
feat(author): a source names the version of its type it was built with, and the build writes it - #257
Merged
Merged
Conversation
…h, and the build writes it (#219)
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 11 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…braries the README means (#219)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #219, its last item to build: "the source handed over beside a package is built again later, on the build page, with a newer pack, so it should name the pack it was built with". #219 stays open.
What changes
builtWith, the content type and the pack's version of it, besidetype:"builtWith": "H5P.Blanks 1.14". It isresult.sourceandresult.builtWith, in Node and in a page.builtWith was H5P.TrueFalse 1.2 and this pack has H5P.TrueFalse 1.8: its fields may have changed since, so play it through before handing it over. Where it has problems, one more line with them, since a field that changed may have made them. Alone it is never a problem.<package>.source.jsonbeside the package, as the MCP server already did; both now writeresult.source. It is never written over: a name that is taken stops the build before a package is made. The one exception is the file being built (the usual name of a source that was handed over), which is rewritten by a rename, and only where what it names has changed. A quiz in the quiz format stays as written.built-here.md, one sentence).Two choices, the owner's
parts/folder too, whose index names no pack; and it says what moved.Not in this change
builtWithout; the next build writes it.buildPackageitself still writes the package alone.Tested
rivers.h5pandrivers.source.jsonwith the fixed line as written.Behaviour that changes for people
h5p-author build a.json b.h5pnow also writesb.source.json, and refuses where that name is taken by another file.builtWith;sourceSchemahas the field, described as a build's to write.Summary by cubic
Part of #219: a source handed over beside a package is built again later, often with a newer pack, so a build now stamps the source it returns with
builtWith, the content type and the pack's version of it (H5P.Blanks 1.14), beside itstype, and says so when a source names another version of its type. The command line now writes that built source as<output>.source.jsonbeside the package, and the skill's hand-over gives that file, not the one the chat wrote.Behavior changes
h5p-author build a.json b.h5pnow writesb.source.jsontoo, and refuses before a package is made where that name is taken by another file; the file being built is the exception, kept up to date. A quiz in the quiz format built to a new name is kept beside the package as the source it was built as, which takes the field; the file itself stays as written. The MCP server likewise writes the source the build returned, not the one given.builtWithis a field ofsourceSchema, described as a build's to write and left out of the fields a problem lists as a source's; a value that is not a name and a version is a problem saying to leave it out.buildPackagehands backsourceandbuiltWithin Node and on a page, and still writes the package alone.Written for commit 3f88473. Summary will update on new commits.