Repository navigation
deps: h5p-author 0.15.0, and the build page saves the source it built - #85
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #84.
What changes
@missing-elements/h5p-author0.14.0 → 0.15.0, which brings h5p-normalize 1.5.0 with it. The build page, the sample, the type files, the skill's zips and/h5p/bundles/all come from it, as before.<name>.source.json, the source as the build took it, withbuiltWithnaming the version of its content type. The box keeps the text as the person wrote it. A hint under the buttons says to keep the source with the file, and why.What 0.15.0 changes in the page's build without code here:
vimeo.com/1are refused, with what to give instead;Checked, on 0.15.0 from npm
pnpm run buildpasses./h5p/bundles/h5p-author.mjsreports 0.15.0 and is byte-equal to the package'sdist/. The archive's tool reports 0.15.0, builds a True/False fromparts/, and writes its.source.jsonwith"builtWith": "H5P.TrueFalse 1.8".writing-learning-objectives-with-bloom-s-taxonomy.source.json, startingtype,builtWith: "H5P.CoursePresentation 1.27".builtWithset to 1.26 it gives the note.youtu.be/aaaaaaaaaaaandvimeo.com/1are refused with the messages above, asked of each site's oEmbed from the page.Summary by cubic
Closes #84: upgrades
@missing-elements/h5p-authorto 0.15.0 (bringingh5p-normalize1.5.0) and lets the build page save the source it built as<name>.source.json.Written for commit 03fcebe. Summary will update on new commits.