Repository navigation
feat(play): the play page asks for the files a source names - #89
Merged
Merged
Conversation
An activity that uses a file of the person's own, a video beside the source, was sent to the build page. The page now names the files and takes them: chosen from the computer, or given by the frame's parent. One file named and one of the same kind chosen is a match whatever it is called. They are read in the browser and go nowhere.
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…#88) A parent that answered each needs-files with the same files, some of them, was asked again with every answer, without end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #88.
An activity that uses a file of the person's own, such as an Interactive Video made from a video they attached in the chat, now plays on the play page. Until now the page sent it to the build page.
needs-filesto its parent with the names, and takes{ source: 'h5p-play-host', type: 'files', files }from it.Why: in ChatGPT on 2026-11-20 the app got a piece of text in place of the attached video, three runs out of three (openai/openai-apps-sdk-examples#237, comment of 2026-10-22). So the card can't rely on the chat app for the file.
Checked:
pnpm buildpasses.Summary by cubic
Closes #88.
The play page now plays activities that use files of the person's own, like an Interactive Video made from a video they attached in a chat; until now it sent them to the build page.
needs-filesto its parent and takes{ source: 'h5p-play-host', type: 'files', files }from it.Why: in ChatGPT, the app received a piece of text in the place of an attached video, three times out of three, so the card can't rely on the chat app for the file.
Written for commit 85e73e1. Summary will update on new commits.