chore(deps): bump marked from 15.0.12 to 17.0.6#2012
Draft
martin-helmich wants to merge 1 commit into
Draft
Conversation
Dependabot's bump (#1770) has been stuck since April because marked-terminal@7.3.0 (the latest release) still declares a `marked >=1 <16` peer dependency, so `npm install` fails to resolve in CI even though yarn is lenient about it. marked-terminal 7.3.0 renders correctly against marked 17 at runtime (verified against the conversation-show render path: headings, bold, italic, inline/fenced code, lists, blockquotes and links all work), and upstream has no release that widens the peer range (see markedjs/marked-terminal#375). Add an npm `overrides` entry so `npm install` accepts marked 17 for marked-terminal, unblocking the "dependencies are resolvable" check. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E63yC1mME5QCHpCyfDmAD6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvages #1770. Dependabot's marked 15 → 17 bump has been stuck since April:
marked-terminal@7.3.0(its latest release) still declares amarked >=1 <16peer dependency, so the "dependencies are resolvable" CI job (npm install) fails to resolve. yarn is lenient about the peer mismatch, which is why compile/lint/test passed there while the npm check stayed red.What this does
markedto^17.0.6.overridesentry sonpm installaccepts marked 17 formarked-terminal, unblocking the resolvable-deps check.Why it's safe
conversation showrender path (marked.setOptions({ renderer: new TerminalRenderer() })+await marked(md)) and headings, bold, italic, inline/fenced code, lists, blockquotes and links all render with correct ANSI output.masterbranch only goes to<17, and the issue tracking this (markedjs/marked-terminal#375) has been open since January with no maintainer response — so waiting on Dependabot alone will never turn this green.npm installnow resolves cleanly (no--legacy-peer-deps), andyarn lint,yarn compile, andyarn testall pass.Once this merges, #1770 can be closed.
🤖 Generated with Claude Code
https://claude.ai/code/session_01E63yC1mME5QCHpCyfDmAD6