Skip to content

feat: Toggleable use_https param for flags - #198

Open
matthewestopinal wants to merge 4 commits into
masterfrom
mestopinal-http-param
Open

feat: Toggleable use_https param for flags#198
matthewestopinal wants to merge 4 commits into
masterfrom
mestopinal-http-param

Conversation

@matthewestopinal

@matthewestopinal matthewestopinal commented Sep 3, 2026

Copy link
Copy Markdown

Defaults to true. Allows disabling use_https to allow passing through http connections without cert checking or failing the TLS handshake. To be used for dev / local environments.

@matthewestopinal
matthewestopinal requested review from a team and rahul-mixpanel September 3, 2026 21:34
@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

The PR appears safe to merge with no outstanding code findings.

The concrete configurations preserve their existing positional layouts, default to HTTPS, and consistently apply the selected scheme to both synchronous and asynchronous clients. Both previous threads were manually resolved.

Important Files Changed

Filename Overview
mixpanel/flags/types.py Places use_https after existing concrete configuration fields to preserve positional argument compatibility.
mixpanel/flags/local_feature_flags.py Selects the local feature-flag client URL scheme from use_https.
mixpanel/flags/remote_feature_flags.py Selects the remote feature-flag client URL scheme from use_https.
mixpanel/flags/test_local_feature_flags.py Covers transport selection, positional compatibility, URL construction, and proxy headers.
mixpanel/flags/test_remote_feature_flags.py Covers transport selection, URL construction, and proxy headers.

Reviews (4): Last reviewed commit: "fix positional bug" | Re-trigger Greptile

Comment thread mixpanel/flags/types.py Outdated
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.48%. Comparing base (091b056) to head (1e5c5d1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
+ Coverage   96.39%   96.48%   +0.08%     
==========================================
  Files          15       15              
  Lines        2888     2959      +71     
  Branches      176      180       +4     
==========================================
+ Hits         2784     2855      +71     
  Misses         67       67              
  Partials       37       37              
Flag Coverage Δ
openfeature-provider 51.20% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@efahk efahk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommend using 'verifyCert' similar to what tracking uses in init.py

Comment thread mixpanel/flags/types.py Outdated
@matthewestopinal matthewestopinal changed the title feat(multi): Toggleable use_https param feat(multi): Toggleable verify_cert param Sep 9, 2026
@matthewestopinal matthewestopinal changed the title feat(multi): Toggleable verify_cert param feat: Toggleable use_https param for flags Sep 9, 2026
Comment thread mixpanel/flags/types.py
class LocalFlagsConfig(FlagsConfig):
enable_polling: bool = True
polling_interval_in_seconds: int = 60
use_https: bool = True

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs to be on the base FlagsConfig

Copy link
Copy Markdown
Contributor

Is this change coming from as customer request? I'd prefer not to lower the security posture, even if https is still the default.

@matthewestopinal

Copy link
Copy Markdown
Author

Is this change coming from as customer request? I'd prefer not to lower the security posture, even if https is still the default.

@tylerjroach This is coming from internal needs to develop against. Some of our internal devbox servers are sending traffic through http, and if we don't have an option to support it here we have to standup a certain amount of infrastructure just to allow a request to go through in devbox

Copy link
Copy Markdown
Contributor

Got it. Maybe we can sync tomorrow and discuss options here a bit more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants