Skip to content

Options in generate are not used in verify #2

Description

@epoberezkin

You can't really use options at the moment because of that.
Options either have to be removed from generate or added to verify

Activity

  1. changed the title [-]Options in generate are not used in validate[/-] [+]Options in generate are not used in verify[/+] on Jun 29, 2015
  2. juancri commented on Jan 4, 2017

    @juancri

    I think it's fixed in this PR: #6

  3. epoberezkin commented on Jan 4, 2017

    @epoberezkin
    Author

    #6 does nothing but code style - these parenthesis don't change the operators precedence.
    The real issue is that you can pass options to generate method that would affect the generated token.
    The same options should be passed to verify method, otherwise the token will be not verified, but this method does not support options.

  4. mixu commented on Jan 5, 2017

    @mixu
    Owner

    good point - happy to accept a PR for this!

  5. derwaldgeist commented on Jul 10, 2021

    @derwaldgeist

    Just stumbled upon this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions