Fix compile_dfs multi-output trace leaks - #4440
Closed
PhilipJohnBasile wants to merge 1 commit into
Closed
Conversation
Remap temporary parent references before replacing the old tape so the existing sibling-cycle breaker can reclaim unreachable trace nodes without mutating externally owned graphs. Add compile and export leak regressions plus an externally owned capture control. Co-authored-by: OpenAI Codex <noreply@openai.com>
zcbenz
added
the
await verification
Member
|
I'm closing this in favor of #4453 which fixes the root cause, please let me know if it is missing anything. |
zcbenz
removed
the
await verification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remap temporary parent references before replacing the old tape so the existing sibling-cycle breaker can reclaim unreachable trace nodes without mutating externally owned graphs.
Add compile and export leak regressions plus an externally owned capture control.