⚡ Bolt: Replace FindObjectsOfType with NetworkMap in LuaServerModule - #255
⚡ Bolt: Replace FindObjectsOfType with NetworkMap in LuaServerModule#255mleem97 wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 15 |
| Duplication | 3 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
💡 What: Replaced
UnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>()with O(1) access viaIl2Cpp.NetworkMap.instance.servers(and.brokenServers) inLuaServerModule.🎯 Why:
FindObjectsOfTypeperforms an O(N) scan of all loaded objects, which creates immense CPU and GC overhead in late-game environments when fetching server lists via Lua.📊 Impact: Reduces CPU time and GC allocations to near zero for Lua server list and repair iterations.
🔬 Measurement: Run a large datacenter save and invoke
greg.server.get_all()orgreg.server.repair_all()in the Lua console; observe the elimination of frame hitches compared to the unoptimized method.PR created automatically by Jules for task 4822099945337846272 started by @mleem97