⚡ Bolt: Optimize hardware entity lookups in HarmonyPatches - #256
Conversation
…nd Switches in HarmonyPatches.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | -180 |
| Duplication | 10 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
1 participant
💡 What: Replaced O(N)
FindObjectsOfTypequeries with O(1) cache lookups fromIl2Cpp.NetworkMap.instancein the fallback logic ofHarmonyPatches.🎯 Why:
FindObjectsOfTypeis a heavy operation that scans the entire scene hierarchy, which negatively impacts game performance when called frequently.📊 Impact: Reduces CPU cost from O(N) to O(1) when finding object IDs for missing server and switch references.
🔬 Measurement: Verified by running
dotnet testand ensuring that entity lookups function successfully without any regressions.PR created automatically by Jules for task 6254557291360504868 started by @mleem97