Skip to content

⚡ Bolt: Optimize server lookups in Lua API - #258

Open
mleem97 wants to merge 1 commit into
mainfrom
bolt-lua-server-optimization-18045748598223504928
Open

⚡ Bolt: Optimize server lookups in Lua API#258
mleem97 wants to merge 1 commit into
mainfrom
bolt-lua-server-optimization-18045748598223504928

Conversation

@mleem97

@mleem97 mleem97 commented Aug 31, 2026

Copy link
Copy Markdown
Owner
  • 💡 What: Replaced O(N) FindObjectsOfType<Il2Cpp.Server>() calls with O(1) dictionary lookups using Il2Cpp.NetworkMap.instance.servers and Il2Cpp.NetworkMap.instance.brokenServers in LuaServerModule. Added a fallback to FindObjectsOfType for uninitialized game states.
  • 🎯 Why: The Lua API methods (get_all, repair, repair_all) were unnecessarily calling FindObjectsOfType, causing CPU overhead and garbage collection pressure, particularly noticeable when these are called frequently via Lua scripts in large data centers.
  • 📊 Impact: Turns O(N) scene-wide component searches into O(1) dictionary iterations, eliminating GC allocations and reducing hitching during script execution.
  • 🔬 Measurement: Observe CPU time and GC allocations in the Unity Profiler when invoking greg.server.get_all() or greg.server.repair_all() in a scene with thousands of servers.

PR created automatically by Jules for task 18045748598223504928 started by @mleem97

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 16 complexity · 1 duplication

Metric Results
Complexity 16
Duplication 1

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant