⚡ Bolt: Optimize server fetching in Lua API - #259
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 6 |
| Duplication | 6 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
💡 What:
Optimized
get_all,repair, andrepair_allinLuaServerModule.csto fetch servers fromIl2Cpp.NetworkMap.instance.serversinstead of callingUnityEngine.Object.FindObjectsOfType<Il2Cpp.Server>().🎯 Why:
FindObjectsOfTypescans the entire object hierarchy (O(N) across all loaded objects), which is extremely expensive, especially in late-game data centers. Repeated Lua script calls to these API endpoints cause main thread hitches and significant garbage collection pressure.📊 Impact:
Converts an O(N) scene-wide scan to an O(1) dictionary lookup (iterating
.Values), virtually eliminating CPU blocking and drastically reducing GC overhead for Lua mods that repeatedly query server state.🔬 Measurement:
Run the application with a Lua script frequently invoking
greg.server.get_all(). Monitor the Unity Profiler and GC allocs per frame to confirm the CPU spike and allocations fromFindObjectsOfTypeare eliminated.PR created automatically by Jules for task 11387833767345434681 started by @mleem97