⚡ Bolt: Optimize EnsureAllRackPositionUIDs with NetworkMap lookups - #261
⚡ Bolt: Optimize EnsureAllRackPositionUIDs with NetworkMap lookups#261mleem97 wants to merge 1 commit into
Conversation
Replaced expensive O(N) `FindObjectsOfType<Server/NetworkSwitch>` calls with O(1) lookups from the game-managed `NetworkMap.instance` collections in `GameHooks.EnsureAllRackPositionUIDs`. Fallbacks remain for uninitialized states. Using `FindObjectsOfType` scans the entire Unity hierarchy, causing unnecessary CPU overhead and garbage collection pressure in late-game data centers. This significantly reduces CPU and memory hit during world syncs/teardowns, avoiding massive GC allocations per call.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 12 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
FindObjectsOfType<Server/NetworkSwitch>calls with O(1) lookups from the game-managedNetworkMap.instancecollections inGameHooks.EnsureAllRackPositionUIDs. Fallbacks remain for uninitialized states.FindObjectsOfTypescans the entire Unity hierarchy, causing unnecessary CPU overhead and garbage collection pressure in late-game data centers.PR created automatically by Jules for task 7407511326281846471 started by @mleem97