refactor: use flowmesh/v1 as the API version in test fixtures - #143
Merged
Merged
Conversation
The apiVersion field is unvalidated, so the stale mloc/v1 strings in test fixtures were inert; align them with the flowmesh/v1 used in production code. Signed-off-by: Noppanat Wadlom <noppanat.wad@gmail.com>
kaiitunnz
force-pushed
the
kaiitunnz/refactor/mloc-to-flowmesh-apiversion
branch
from
September 18, 2026 12:11
a38654d to
ddd3106
Compare
Sweep the mloc/v1 references reintroduced by the rebase (#137's redacted-credential tests) along with the rest. Signed-off-by: Noppanat Wadlom <noppanat.wad@gmail.com>
kaiitunnz
deleted the
kaiitunnz/refactor/mloc-to-flowmesh-apiversion
branch
September 18, 2026 12:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The codebase's canonical API version string is
flowmesh/v1— it is whatsrc/server/task/n8n_parser.pyand the SDK emit, and what the workflow format documents. Test fixtures still carried the stalemloc/v1from an earlier name, so the tests exercised a version string that production never sees. This PR aligns those fixtures with the value production actually uses.Changes
Replace 19
mloc/v1in the test modules withflowmesh/v1.Design
The
apiVersionfield is unvalidated (strinTaskEnvelopeStrict/TaskEnvelopeTemplate,Any | Nonein the workflow parser), so this is a behaviorally inert string replacement in test fixtures — no source, docs, SDK, or CLI files referencedmloc. A single mechanical sweep covers all three syntactic forms the fixtures use.Test Plan
Test Result
pytest tests/ --ignore=tests/worker/test_mp_executor_cleanup_gpu.py→ 1858 passedpre-commit run --all-files→ all seven hooks clean (gitleaks, isort, black, ruff, codespell, mypy, requirements sync)grep -rn "mloc"→ zero references remain outside.venvPre-submission Checklist
pre-commit run --all-filesand fixed any issues.uv run pytest tests/passes locally.uv sync --all-packages --group ci --frozen).[BREAKING]and described migration steps above.