Repository navigation
Docs: redirect targets need the .html suffix - #61
Merged
Merged
Conversation
sphinx_reredirects takes the mapping values as URIs as-is, and this is a plain (non-dirhtml) html build, so 'actions/actions' lands on a 404; the real page is 'actions/actions.html'. All 24 targets were missing it. Verified by parsing each generated stub and resolving its target against the built tree (24/24 exist now).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #60: sphinx_reredirects uses the mapping values as URIs verbatim; with the plain (non-dirhtml) html builder
/en/latest/actions.htmlwas redirecting toactions/actions(404) instead ofactions/actions.html. All 24 targets were missing the suffix.Verification: each generated stub is parsed and its
targetresolved against the built tree -- 24/24 now resolve to real files.