Repository navigation
Fix MoveStraightIn2DActionServer to stop circling the destination point - #62
Open
UnladenCoconut wants to merge 1 commit into
Open
UnladenCoconut wants to merge 1 commit into
UnladenCoconut wants to merge 1 commit into
Conversation
The previous implementation always moved the maximum possible delta x/y, so if the the target wasnt a integer multiple of this it would circle that point when it gets close.
Owner
|
Thanks, @UnladenCoconut. This is an interesting addition. If you could please update this file too https://ros2-tutorial.readthedocs.io/en/latest/actions/actions.html which the explanation behind it and Eq. (2) to clearly show the Many thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation always moved the maximum possible delta x/y, so if the the target wasn't a integer multiple of this it would circle that point when it gets close.
E.g. if you try
ros2 action send_goal /move_straight_in_2d python_package_with_interfaces/action/MoveStraightIn2D '{desired_position: {x: 1.5, y: 1.5 }}' --feedback