Skip to content

Fix MoveStraightIn2DActionServer to stop circling the destination point - #62

Open
UnladenCoconut wants to merge 1 commit into
mmmarinho:mainfrom
UnladenCoconut:main
Open

UnladenCoconut wants to merge 1 commit into
mmmarinho:mainfrom
UnladenCoconut:main

Conversation

@UnladenCoconut

@UnladenCoconut UnladenCoconut commented Nov 9, 2026 •

Copy link
Copy Markdown

The previous implementation always moved the maximum possible delta x/y, so if the the target wasn't a integer multiple of this it would circle that point when it gets close.
E.g. if you try ros2 action send_goal /move_straight_in_2d python_package_with_interfaces/action/MoveStraightIn2D '{desired_position: {x: 1.5, y: 1.5 }}' --feedback

The previous implementation always moved the maximum possible delta
x/y, so if the the target wasnt a integer multiple of this it would
circle that point when it gets close.
@mmmarinho

Copy link
Copy Markdown
Owner

Thanks, @UnladenCoconut.

This is an interesting addition. If you could please update this file too https://ros2-tutorial.readthedocs.io/en/latest/actions/actions.html which the explanation behind it and Eq. (2) to clearly show the min I can have this merged.

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants