Repository navigation
Harden PyPI publishing supply chain - #7
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9662d62e2e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review The prior P1 is addressed in 43b5200. Please review both publish jobs and verify the invariant before either PyPI action runs: the sorted filenames represented by |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Motivation
Description
uses:references in.github/workflows/publish.ymlto reviewed full commit SHAs and replace dynamic installs with reproducible inputs for build tooling..github/build-requirements.txtand changepyproject.tomlbuild-system.requiresto exactsetuptools==80.9.0andwheel==0.45.1so the build dependencies are exact and hash-verified.python -m buildwith a controlled build usingsetuptools.build_metathat writessdist/wheelintorelease/packages, generateSHA256SUMS, and upload therelease/bundle (not the package dir) as the artifact.SHA256SUMSin both the TestPyPI and production publish jobs and passpackages-dirto the publishing action.Testing
python -m pytest -qand all tests passed (84 passed).setuptools/wheelartifacts and verified archives by runningsha256sum --check SHA256SUMS..github/workflows/publish.ymlwithPyYAMLand ran a static assertion that everyuses:reference ends in a full 40-character commit SHA.git diff --checkand a lint pass;ruffreports are expected because YAML/TOML are not Python source and no functional Python files were changed.Codex Task