Skip to content

Pin code review workflow to immutable commit SHA - #8

Merged
parkjinman98 merged 2 commits into
mainfrom
codex/fix-mutable-workflow-security-vulnerability
Sep 22, 2026
Merged

parkjinman98 merged 2 commits into
mainfrom
codex/fix-mutable-workflow-security-vulnerability

Conversation

@parkjinman98

Copy link
Copy Markdown
Contributor

Motivation

  • Prevent execution of unreviewed, mutable upstream workflow code by replacing the @main reusable-workflow reference with a reviewed immutable commit SHA to close a supply-chain trust gap.

Description

  • Replace the uses: mobilint/.github/.github/workflows/codex-pr-review.yml@main line in .github/workflows/code-review.yml with the immutable commit SHA b72f65626cc60deaa23b84d28ce684b4ee583a20, preserving existing triggers and declared permissions.

Testing

  • Verified the change with a small Python assertion that the uses: reference is a 40-character SHA; ran PYTHONPATH=. pytest -q (84 passed); ran git diff --check; note that actionlint was not installed in the environment.

Codex Task

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-22T08:49:35.687847Z e494b2c Manual request
🔒 Security Review ✅ Completed 2026-09-22T08:52:25.706374Z e494b2c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1ebb59ef9f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/code-review.yml Outdated
@parkjinman98 parkjinman98 self-assigned this Sep 22, 2026
@parkjinman98

Copy link
Copy Markdown
Contributor Author

@codex review

The prior P1 is addressed in e494b2c. Please verify the uses: revision against the source repository mobilint/.github, not this caller repository: commit a28ab7620743e01d1916ee878d8726c22ecfd97b contains .github/workflows/codex-pr-review.yml (workflow blob c9e5172c0840650007388c054637782fc886933c). Check that the reusable workflow resolves at that immutable source commit and review the updated head.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: e494b2cd1a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: e494b2cd1a

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@parkjinman98
parkjinman98 merged commit 0e56ce4 into main Sep 22, 2026
3 checks passed
@parkjinman98
parkjinman98 deleted the codex/fix-mutable-workflow-security-vulnerability branch September 22, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant