Repository navigation
Spanish localization (draft) and English plural forms - #92
Open
ufortstephen wants to merge 2 commits into
Open
ufortstephen wants to merge 2 commits into
ufortstephen wants to merge 2 commits into
Conversation
"1 clips and 1 pinboards" and similar strings now read "1 clip and 1 pinboard". Adds English plural variations to every count that can be 1: the iCloud upload messages, the history retention and clear-history confirmations, import results, character counts, the iPhone delete confirmation and the trial days left. Korean and Chinese have no plural forms, so their translations are unchanged.
Adds es to both String Catalogs, covering Settings, the panel, menus, onboarding and alerts on Mac and iPhone, and to the declared app languages in the Mac, Mac App Store and iPhone Info.plists and the READMEs. Every placeholder matches the English and every count has its Spanish plural forms. Keyboard shortcuts stay as macOS shows them (⌘⇧V). Terms follow Apple's Spanish: Ajustes for Settings, Vista Rápida for Quick Look; a pinboard is a tablero and a clip stays a clip. The translations are a machine draft and need review by a native speaker.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48
Two commits, as you asked:
esin both catalogs, inCFBundleLocalizationsfor the Mac, Mac App Store and iPhone apps, and in both READMEs.A correction to what I wrote on the issue
The 5 iPhone strings I said were missing Korean and Chinese (
%@ selected,%@ clips,%@ of 2and the two iCloud upload messages) are not showing English to anyone. The code interpolatesInts, so SwiftUI looks up%lld selected,%lld of 2and so on, and those keys already have Korean and Chinese inClipbaraKit/Resources/Localizable.xcstrings. I built the iPhone app and checked the compiledko.lproj: all five are there in Korean. The%@entries next to them are unused copies, added indd7f0ce. I misread the catalog the first time, sorry for the noise.Two things worth knowing, though I left both alone:
%lldkeys are marked stale in the Kit catalog even though the app uses them. If anyone runs Xcode's "Remove stale strings" on it, the Korean and Chinese for them would be deleted.%@copies are unused and could be deleted.Commit 1: plurals
"1 clips and 1 pinboards" now reads "1 clip and 1 pinboard". The same fix applies to:
Strings with more than one count use a substitution per count, so "1 clip and 3 pinboards" works too. No Swift code changed.
Commit 2: Spanish
Your checklist:
esadded. The App Store description stays with you, as you said.Terms follow Apple's Spanish: Ajustes for Settings, Ajustes del Sistema, Vista Rápida for Quick Look, and the iOS paths as iOS shows them ("Ajustes > General > Teclado > Teclados > Añadir nuevo teclado"). A pinboard is a tablero and a clip stays a clip. It uses "tú" throughout.
This is a machine draft. I reviewed it and corrected about a hundred strings by hand, but it hasn't been read by a native speaker. If the Reddit user can take a look,
esin the twoLocalizable.xcstringsfiles is all there is to read.Checks
es.lproj.ClipbaraTestspass (106 + 15 tests).main: the extensions need your signing and app group.