Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to docker/buildx#4079
This extracts the archive detection helper from #7034 as
compression.IsArchiveso BuildKit and Buildx can share the same format detection, including zstd skippable frames. The Dockerfile frontend now uses this helper, and layer compression detection reuses its gzip and zstd prefix checks. This keeps the shared detection independent of the decompression and archive extraction changes in #7034.Related to docker/buildx#4079, which fixes zstd-compressed contexts being interpreted as Dockerfiles on stdin. Buildx performs that classification before uploading the context, so BuildKit frontend support alone cannot fix it. Once Buildx vendors BuildKit containing this change, the follow-up is to replace its local
build.isArchiveimplementation withcompression.IsArchive. This addresses the detection gap without maintaining a second magic-byte table.