Repository navigation
feat(installer): drop jq - #2
Merged
Merged
Conversation
Replace every jq call with a small POSIX awk reader that flattens JSON to path/value lines. Its contract is deliberately narrow: only \" \ \/ are decoded, other escapes stay as text, raw control characters and anything malformed exit 2, so a value can never forge a line or split a path. curl and the POSIX base are now the only hard requirements. Native .deb/.rpm packages are taken from the manifest's linux-*-deb/-rpm keys, which every release of both consumers has carried, and are therefore verified with the manifest signature like every other asset. The GitHub Releases API discovery, its token plumbing and the "verifying via HTTPS only" path are gone; github_repo is read and ignored. When a pubkey is configured and minisign is missing, offer to install it through the detected package manager (apt, dnf, zypper, pacman, brew) under the existing consent and sudo flow; declining, a failed install or no known manager leaves the explicit error. Dry runs never offer. The uninstall manifest is written with printf and read with the same reader; its shape is unchanged.
ShulhaOleh
changed the title
ShulhaOleh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the
jqruntime requirement and make the updater manifest the only source of assets.\"\\\/decoded, malformed input fails);curland the POSIX base are now the only hard requirements.deb/.rpmcome from the manifest'slinux-*-deb/-rpmkeys and are signature-verified like every other asset; the GitHub Releases API discovery and its token plumbing are gone (github_repois read and ignored)pubkeyis set andminisignis missing, offer to install it via apt/dnf/zypper/pacman/brew under the existing consent/sudo flow; declining or a failed install keeps the explicit error; dry runs never offerTests: 21 cases (reader cross-checked against
jqon both live manifests and adversarial fixtures, native selection/signature for deb and rpm, AppImage fallback, minisign accept/decline/fail/no-manager). Passed on Debian 13; Fedora and macOS run in CI.