Skip to content

fix(ci): map shared files to the lanes they affect - #190

Merged
ShulhaOleh merged 1 commit into
mainfrom
fix/ci-path-filter
Oct 27, 2026
Merged

ShulhaOleh merged 1 commit into
mainfrom
fix/ci-path-filter

Conversation

@ShulhaOleh

Copy link
Copy Markdown
Member

Summary

CI ran every lane, including both Rust jobs, on PRs that could not affect them. The global filter matched every file outside its exclude list and forced a full run, so files missing from that list, such as the PR and issue templates, the root package.json and .TODO, ran everything. #160, #179, #180, #183 and #184 all ran Rust this way.

  • Remove the global catch-all. A file outside every lane's paths now runs no conditional lane.
  • Map shared root files to the lanes that read them: package.json, bun.lock and bunfig.toml to the JS lanes, rust-toolchain.toml to Rust and licenses, tsconfig.base.json and types to the TypeScript lanes, .gitattributes to all of them.
  • The Rust jobs run Cargo directly and read nothing from the root package.json, so skipping them there is safe.

Changes to ci.yml itself, scheduled and manual runs, and PRs with 3,000 or more files still run every lane. The weekly scheduled run catches a shared file that a lane depends on but that no filter maps yet.

Type of change

  • Bug fix
  • Feature
  • Improvement
  • Translation
  • Maintenance (CI, build, tooling, refactors)
  • Dependencies
  • Documentation only

Validation

  • Full local repository checks (bun checks)
  • Relevant local checks
  • CI only
  • Not applicable

Details: Replayed the last 30 PRs against the new filters with the matcher the action uses. The five false positives skip Rust, and every PR that changed Rust inputs still runs it. This PR runs every lane because it changes ci.yml.

@ShulhaOleh ShulhaOleh added the maintenance CI, build, tooling, refactors, release plumbing label Oct 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Deploying Modrex previews with  Cloudflare Pages  Cloudflare Pages

App preview:https://app-preview.modrex.net/pr/190
Site preview:https://site-preview.modrex.net/pr/190

View logs: app | site

@ShulhaOleh
ShulhaOleh merged commit 7dd4b80 into main Oct 27, 2026
17 checks passed
@ShulhaOleh
ShulhaOleh deleted the fix/ci-path-filter branch October 27, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance CI, build, tooling, refactors, release plumbing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant