Repository navigation
fix(ci): map shared files to the lanes they affect - #190
Merged
Merged
Conversation
Contributor
Deploying Modrex previews with
|
| App preview: | https://app-preview.modrex.net/pr/190 |
| Site preview: | https://site-preview.modrex.net/pr/190 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI ran every lane, including both Rust jobs, on PRs that could not affect them. The global filter matched every file outside its exclude list and forced a full run, so files missing from that list, such as the PR and issue templates, the root package.json and .TODO, ran everything. #160, #179, #180, #183 and #184 all ran Rust this way.
Changes to ci.yml itself, scheduled and manual runs, and PRs with 3,000 or more files still run every lane. The weekly scheduled run catches a shared file that a lane depends on but that no filter maps yet.
Type of change
Validation
bun checks)Details: Replayed the last 30 PRs against the new filters with the matcher the action uses. The five false positives skip Rust, and every PR that changed Rust inputs still runs it. This PR runs every lane because it changes ci.yml.