Repository navigation
Redesigns R1-R4: testing cockpit, identity rail, risk-graded outputs, quiet lock station - #22
Merged
Merged
Conversation
added 4 commits
October 6, 2026 08:43
…eed testing cockpit (record lane first, disclosed plan lane with live count), R2 patient identity rail (primary fields always visible, wrap never scroll; dedicated mobile title row), R3 risk-graded output actions (local/external/research tiers with on-control data boundaries), R4 quiet lock station (ambient decoration removed, non-motion error state)
… gating (protocols/notes/custom editors hidden while recording), section actions before plan lane, plan-lane auto-collapse/open with manual override, empty-state plan link, protocol/dilution summary, 44px sm-to-xl targets, filter aria-label, pulse removed, conditional aria-controls; identity landmark renamed to Active patient identity, three-row mobile rail, visit-date redaction, masthead token on mobile title; offline disable with explanations for email/research, mailto recipient matches displayed destination, aria-live/alert on research states, dialog focus restoration; strengthened tests (4 new R1 behavior tests, reduced-motion targets animated element, rail+stack height bounds)
…plan variants so per-drug plan content renders in the plan lane after section actions (record → actions → plan order); plan-lane state lifted to TestingLogForm (persists across section navigation); session-panel predicate counts custom (Other) rows with stable custom-* ids in count/summary/auto-effects; unconfigured custom additions keep the lane open instead of fighting auto-collapse; auto-open effect removed in favour of the collapse-skip (respects manual override); dialog focus restoration falls back to the research status banner when the trigger was replaced; new regression tests for custom counting, navigation persistence, and both focus-restoration paths
…undActionDialog conditionally, so the open-effect cleanup now performs restoration (covers both unmount and open-to-closed paths); fallback targets the research status banner when the trigger was replaced; focus tests reproduce the real conditional-mount lifecycle
monchee
force-pushed
the
redesigns-r1-r4
branch
from
October 5, 2026 21:43
b5b45b6 to
431725a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementation of all four redesign shape specs (docs/design-specs/2026-10-05-r*.md) from plan 003, following GPT's design audit:
Review
Three GPT review rounds (gpt-5.6-luna max): round 1 found 17 defects (fixed), round 2 found 6 (fixed), round 3 found 1 (fixed), round 4: APPROVED.
Verification
tsc clean, eslint clean, 930 unit tests passed, 59 e2e tests passed (exit 0). Impeccable detector: 0 non-advisory findings on changed files. Visual snapshots updated only for the intended R2 mobile top-bar restructure.