Repository navigation
Plan 004 review fixes — warning wiring, truthful imports, sign-off gate, docs accuracy - #27
Merged
Merged
Conversation
added 7 commits
October 10, 2026 08:50
…tingScreen via App; truthful Dashboard imports (both flows) and GetStarted return path; plan-builder draft failure state; persistDraftNow cross-tab guard; split failure-mode spec (CI-safe navigation/cross-tab vs local-only storage interception, documented); add SW unlocked-update prompt test; assert Forward-with-guard and stored-draft unchanged in two-tab; fix dark-contrast alpha handling and scan +POS surface; fix sync-protocols mkdirSync import; enforce clinical sign-off gate (fingerprint + Decision/Reviewer/Reviewed check, --accept after sign-off); README version current, DREAM_DEV_PORT actually overrides the server command, check:release documented; delete leftover debug spec
…letes the M1 warning-delivery wiring)
…fore contrast scan; version bump + changelog for the fixes PR (release guard by design)
… race on slower machines); SW update test scoped to local verification with documented limitation (plan STOP condition: report rather than silently downgrade); limitation recorded in plans/README
…scribe-level skip was cascading to the whole accessibility suite); local-only scope documented
… existing signed report BEFORE overwrite; --accept verifies same fingerprint + affirmative decision and preserves the sign-off block; REJECTED/maybe decisions refuse; --review-only never writes); report-save failure test moved to CI-safe describe; storageWarning cleared on reset/clear; DashboardScreen boolean type propagated; README version current; check:release in MAINTAINERS
…view-only returns before ANY write in both branches (including no-diff); ACCEPTED report (with verbatim preserved sign-off block: Decision/Reviewer/Role/Reviewed/Scope-notes) is written BEFORE snapshot/masterlist so the durable signed artifact is never behind the clinical data; hasClinicalSignOff requires affirmative decision (REJECTED refuses); per-test CI skips in the storage-interception describe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes all 16 defects from the GPT review of plan 004 (13 DEFECT + 3 actionable NITs):
Verification: tsc clean, lint clean, 928 unit tests, e2e green locally (full suite), CI pending on this PR.