Conversation
nbbeeken
requested review from
esvm
and
a lite review from Copilot
and removed request for
Copilot
September 14, 2026 19:56
|
Coverage is 78.199% — ns-docs into main. No base build found for |
esvm
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds TSDoc to our various isX classifications. The text is based only on the implementation, to elevate the meaning to outside packages.
I just want to hover isSpecialish and be reminded what that means.
Drive-by: moving RegExp up to module scope makes construction 3x faster, mainly
new RegExp('...')is slowOpen Questions
None
Checklist