fix(keymap): highlight Arabic lam-alef key as single key (@byseif21) - #8325
Open
yehiahesham2938 wants to merge 1 commit into
Open
fix(keymap): highlight Arabic lam-alef key as single key (@byseif21)#8325yehiahesham2938 wants to merge 1 commit into
yehiahesham2938 wants to merge 1 commit into
Conversation
monkeytypegeorge
added
frontend
github-actions
Bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Arabic 101/102 keymap legend data to represent lam‑alef as a canonical multi-codepoint sequence, and relaxes schema validation so layouts can carry multi-character legends.
Changes:
- Allow multi-character key legends in
@monkeytype/schemaslayout schema. - Update
arabic_101/arabic_102layout JSON to use canonical sequences (لا,لآ,لإ,لأ) instead of presentation forms. - Add a converter spec for
arabic_101; also includes an unrelated burst-history change in stats.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/schemas/src/layouts.ts | Relax key legend string constraint to permit multi-char legends. |
| frontend/static/layouts/arabic_101.json | Swap Arabic ligature presentation forms → canonical sequences. |
| frontend/static/layouts/arabic_102.json | Same as arabic_101 for 102 layout. |
| frontend/src/ts/test/events/stats.ts | Burst-history predicate now includes composition input type for Korean context (scope creep vs PR). |
| frontend/tests/components/pages/test/keymapConverter.spec.ts | Adds coverage for arabic_101 canonical multi-char ligature conversion. |
Comment on lines
+1136
to
+1139
| ); | ||
|
|
||
| expect(row4?.[4]).toEqual(expectLegend("لا", "لآ")); | ||
| }); |
Comment on lines
+267
to
+271
| (e) => | ||
| e.type === "input" && | ||
| (e.data.inputType === "insertText" || | ||
| (eventLog.context.koreanStatus && | ||
| e.data.inputType === "insertCompositionText")), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
arabic_101andarabic_102layouts.arabic_101.jsonandarabic_102.jsonto use canonical Arabic Unicode sequences (لا,لآ,لإ,لأ) instead of presentation form characters (\uFEFB, etc.).KeyLegendsSchemainpackages/schemas/src/layouts.tsto support multi-character key legend strings.Checks
packages/schemas/src/layouts.tsfrontend/static/layoutsCloses #6411