[DMP 2026] Implement Biometric Quality Through SDK During Biometric Capture

[Mohit14036]

Summary

Introduces a pluggable, multi-source biometric quality evaluation system (SBI + SDK) to replace the previous single-source (SBI-only) quality check, bringing the registration client into full compliance with the Biometric Quality spec's error-handling and scoring rules.

Core orchestrator (BiometricQualityOrchestrator)

• Runs one or more configured evaluators (SBI, SDK) per captured biometric attribute via IBiometricQualityEvaluator, each producing an independent score.
• Combines multi-evaluator scores through a pluggable IBiometricScoreAggregator: Mean, Median, Weighted Average, Priority, Formula (SpEL-based, e.g. #scores['SDK'] * 0.6 + #scores['SBI'] * 0.4), and Max.
• Aggregation strategy resolves through a per-attribute → per-modality → global-default config hierarchy (mosip.registration.quality.aggregation.*), and is genuinely optional — leaving it unset means no aggregate is displayed or used (the score bar and packet fall back to the raw SDK/SBI score). Internally, the orchestrator still computes a MEAN aggregate on every capture as part of its normal flow, but that value is discarded rather than surfaced unless a strategy was explicitly configured, gated via OrchestrationResult.isAggregationExplicitlyConfigured().
• SDK evaluation runs with a real, enforced timeout (ExecutorService), configurable per evaluator.

Spec-compliant error handling

• Enforces the Error Scenarios table's exact blocking/no-fallback semantics and error codes: Invalid SDK Score, SDK Exception, Missing SBI Score, No Quality Source, Quality Below Threshold, Partial Capture, Corrupt Data, Configuration Error, Audit Log Failure (logs a warning instead of breaking evaluation when audit persistence itself fails).
• Unified three previously-inconsistent score-fallback gates (capture-time threshold check, screen "can continue" validation, DTO save gate) so all three now use the same precedence (aggregate > SDK > raw SBI) instead of a passing SDK/aggregate score being silently overridden by a lower raw SBI score.
• Quality-check errors now surface as operator-facing UI alerts instead of being silently swallowed.

SDK owner metadata in CBEFF

• Each BIR's Others map now carries the SDK's own self-reported identity (SDK_SCORE_ORGANIZATION, SDK_SCORE_ORGANIZATION_TYPE, SDK_SCORE_SDK_VERSION, SDK_SCORE_API_VERSION) alongside SDK_SCORE, mirroring the Organization already carried in the primary Quality tag's Algorithm.
• New SdkInfoProvider resolves the real SDKInfo from whichever SDK is configured (mosip.fingerprint/iris/face.provider), since the existing BioAPIFactory/iBioProviderApi never expose it — resolved once per modality and cached.

UI

• Biometric capture screen's pass/fail (red/green) highlighting now applies to whichever score is actually driving the threshold decision (aggregated → SDK → MDS), colors the caption label together with its value, shows the full caption text without truncation, and never changes font size.
• Global Config Settings screen made fully editable.
• Local-config self-healing sync fixed between spring.properties and the GLOBAL_PARAM/LOCAL_PREFERENCES DB tables for quality config keys.

Config

• New mosip.registration.quality.* property tree: evaluator selection, per-modality/per-attribute aggregation strategy, per-attribute weights, formula expressions, and per-evaluator timeouts — all with sensible fallback defaults.

Test plan

• Unit test suite covering Alternate Scenarios AS-01–AS-05 and the full Error Scenarios table (QualityErrorScenariosTest, BiometricQualityOrchestratorTest, MultiVendorOrchestratorTest, FullOrchestratorWithMockSdkTest, SampleSdkIntegrationTest, MockSdkRealIntegrationTest).
• Live end-to-end verification against the mock SBI + mock SDK stack: per-modality aggregation strategies, FORMULA strategy with a custom SpEL expression, and a full real registration capture confirmed to produce the new SDK_SCORE_* fields in the actual CBEFF packet.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (15)

• ^main$
• ^master$
• ^master-java21$
• ^develop$
• ^develop2$
• ^develop/.*
• ^release$
• ^release/.*
• ^release-.*
• ^\d+.\d+.x$
• ^\d+.\d+.\d+$
• ^hotfix/.*
• ^hotfix-.*
• develop
• release-*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 630dcbff-ebf1-41f8-a4e3-648ed3279986

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Mohit14036]

All review comments have been addressed. Please let us know if there are any other issues that need to be resolved.