Repository navigation
Conversation
himanshu748
marked this pull request as ready for review
October 12, 2026 08:12
Owner
|
appreciate this but this is ai thinking... this is just not a real edge case in the history of .env files. no one uses proto as a key name. not worth the added complexity to support such a non-existent edge case. |
Owner
|
oops that comment above was meant for a different PR. reviewing this one now. |
Contributor
Author
Lol🥲will wait. |
Owner
|
merged. thanks! will go out shortly as x.x.8 |
renovate Bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Oct 17, 2026
| datasource | package | from | to | | ---------- | ------- | ------ | ------ | | npm | dotenv | 18.0.7 | 18.0.8 | ## [v18.0.8](https://github.com/motdotla/dotenv/blob/HEAD/CHANGELOG.md#1808-2026-10-14) ##### Changed - Fast parser should strip appended extra quotes ([#1073](motdotla/dotenv#1073)) - Type detail improvement ([#1074](motdotla/dotenv#1074))
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
populate() accepts undefined input values and preserves them in its result, but DotenvPopulateOutput currently declares every value as string.
Change the output index signature to string | undefined. Add a strict TypeScript regression that rejects assigning an undefined-capable populated value to a required string, plus a runtime test documenting the existing behavior for empty and populated targets with override: true.
This is a declaration correction; the runtime implementation is unchanged. Consumers using strict null checks may need to narrow a populated value before treating it as a string.
Validation recorded in the 12 October 2026 handoff on Linux, Node 24.19.0 and npm 11.9.0:
The Windows executable/batch-shim case was skipped on Linux. The full Ubuntu/Windows and Node 20/22/24/26 matrix was not run.
AI assistance: Codex assisted with this contribution and regression validation.