Repository navigation
Version 0.19.1 - #193
Merged
Merged
Version 0.19.1#193
Conversation
The GUI stores an absolute path when a part is imported from another folder or the job has not been saved yet. Planning went through the job parser, which refused that path. Accept absolute source paths in campanion-job/1 and campanion-lathe/1, plan unsaved jobs from the path in memory, and prefer a relative path on Save when one can be formed. Refs only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate toolpaths after importing a part from another folder, or before the job is saved.
The job parser required
source.pathto be relative to the job file. The GUI stores an absolute path when the job has not been saved yet, or when the part lives in a different folder, so Generate failed with "source path must be relative to the job file."campanion-job/1andcampanion-lathe/1now accept an absolute source path as well as a relative one. Unsaved jobs plan from the absolute path already in memory. On Save, the GUI stores a path relative to the job file when one can be formed (including..); otherwise it stores the absolute path.CAMpanion is still primarily command-line driven; the GUI is a work in progress and has not been machine-tested.
Refs only.