Upgrade to dbus-rs 0.9.12 - #47
Open
saschanaz wants to merge 1 commit into
Open
Conversation
|
Verified on real hardware (Arch-based CachyOS, rtkit 0.14, KDE Plasma, rustc 1.97.1): this PR behaves identically to master on the RtKit path.
The local failures look environmental rather than dbus-related:
So: no regression attributable to the dbus-rs 0.9.12 upgrade. Follow-up ideas: a dbus-build skip-guard mirroring the non-dbus one, and capping the stress test's thread count below rtkit's burst limit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=2061689
Please double check with tests before merging.
This builds, but I'm not quite sure it works as tests fails locally on my environment, even on the current master branch. And there's no CI with tests, so I'm not even sure whether the tests ever passed. Maybe some documentation about the testing environment would be nice.