Support triggering the bug-fix agent for follow-ups when mentioning @hackbot#6353
Draft
suhaibmujahid wants to merge 3 commits into
Draft
Support triggering the bug-fix agent for follow-ups when mentioning @hackbot#6353suhaibmujahid wants to merge 3 commits into
@hackbot#6353suhaibmujahid wants to merge 3 commits into
Conversation
Both consumers run in hackbot-api's event loop (the webhook route and the apply handler awaited by the action applier), so the Conduit client is now async (httpx.AsyncClient). The apply handler's helpers become async, with _repository_phid cached via async-lru instead of functools.lru_cache.
marco-c
reviewed
Jul 20, 2026
Comment on lines
+155
to
+164
| user_prompt = ( | ||
| f"Follow up on Phabricator revision D{revision_id} for bug {bug}.\n\n" | ||
| f"A reviewer left a comment (see the instructions in your system " | ||
| f"prompt). Address it: investigate, make the necessary source " | ||
| f"changes, and verify the fix. When you are done, submit your " | ||
| f"changes by calling submit_patch with revision_id={revision_id} so " | ||
| f"the existing revision D{revision_id} is updated — do not create a " | ||
| f"new revision.\n\n" | ||
| f"Consult the relevant rules in {rules_path} if they apply." | ||
| ) |
Collaborator
There was a problem hiding this comment.
it would also be nice to support the use case where the comment is just a question for hackbot to answer. I can imagine a reviewer asking a question about a patch (e.g. "verify this can't do bla bla bla"), either from hackbot or also from another engineer.
Member
Author
There was a problem hiding this comment.
Yes, I will update it to support that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR car be reviewed commit by commit
This PR will add support to trigger the bug-fix agent for follow-ups when mentioning
@hackbotin a comment on a Phabricator revision.