Conversation
marco-c
force-pushed
the
parallel_hashes
branch
2 times, most recently
from
September 14, 2026 17:09
8abef66 to
92f7369
Compare
marco-c
force-pushed
the
parallel_hashes
branch
from
September 14, 2026 17:14
92f7369 to
2241857
Compare
marco-c
marked this pull request as ready for review
September 14, 2026 17:17
La0
reviewed
Sep 16, 2026
La0
left a comment
La0
left a comment
Collaborator
There was a problem hiding this comment.
Not much to say on the refactoring, I'll test on a revision and report on perf.
| self.patch = patch | ||
|
|
||
| @property | ||
| def local_repository(self): |
Collaborator
There was a problem hiding this comment.
Nit: could be named local_repository_path to explicitly state this does not provide a Repository instance
Collaborator
|
On a clean repo (full checkout) on that branch: Second run (no checkout): On current master 7bbadf2 , warm cache (no checkout): That test revision is pretty inconclusive as it had very few hashes to calc (almost all issues silent). I'll retry with a revision with more publishable issues |
Collaborator
Author
|
The case I saw was in https://firefoxci.taskcluster-artifacts.net/ErAfZ8x-Tymdm4O5QCsU8A/0/public/logs/live_backing.log, you could try with that revision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3638