Bug 2033336 - Normalize paths in rename_external_files - #1530
Open
nicolas-guichard wants to merge 2 commits into
Open
nicolas-guichard wants to merge 2 commits into
nicolas-guichard wants to merge 2 commits into
Conversation
normalize_path failures are expected with unified builds, don't let them spam the logs.
The rename_external_files function used to output paths such as: ``` /builds/worker/workspace/obj-build/modules/libpref/./../../../../checkouts/gecko/modules/libpref/Preferences.cpp ``` This was eventually normalized to: ``` /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp ``` But that normalization happened too late, after the removal of the prefix set with the -p option. We need to normalize these somewhere between rename_external_files and the remove_prefix call in rewrite_paths. I chose to do it here to limit potential side effects to a minimum.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rename_external_files function used to output paths such as:
This was eventually normalized to:
But that normalization happened too late, after the removal of the
prefix set with the -p option.
We need to normalize these somewhere between rename_external_files and
the remove_prefix call in rewrite_paths. I chose to do it here to limit
potential side effects to a minimum.