Repository navigation
fix(source-map-consumer): validate line and column arguments - #558
Open
user-Param wants to merge 7 commits into
Open
user-Param wants to merge 7 commits into
user-Param wants to merge 7 commits into
Conversation
Author
|
All 190 tests pass. The fix is minimal and focused. Would appreciate a review! |
Author
|
@hbenl Could you please review this PR? All 190 tests pass and the fix addresses a real issue. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #450 - originalPositionFor was not validating that line and column arguments are provided. When called with null/undefined or missing line/column, needle.generatedLine would be undefined, and undefined < 1 evaluates to false, allowing NaN to propagate into native code. Now throws a clear error when line or column is missing.