Repository navigation
fix(indexed): apply lineShift before comparing with next section offset - #562
Open
user-Param wants to merge 1 commit into
Open
user-Param wants to merge 1 commit into
user-Param wants to merge 1 commit into
Conversation
In IndexedSourceMapConsumer.generatedPositionFor, allGeneratedPositionsFor, and eachMapping, the section-boundary check compared the section-relative generated line against the next section's absolute generated line offset before applying lineShift. This meant the clamp never triggered for sections with a nonzero line offset, leaving lastColumn as Infinity. Fixes mozilla#542 and mozilla#539.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #542 and #539.
In IndexedSourceMapConsumer.generatedPositionFor, allGeneratedPositionsFor,
and eachMapping, the section-boundary check compared the section-relative
generated line against the next section's absolute generated line offset
before applying lineShift. This meant the clamp never triggered for sections
with a nonzero line offset, leaving lastColumn as infinity.
Fixes #542 and #539.