-
Notifications
You must be signed in to change notification settings - Fork 46
into/from_parts #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Baptistemontan
wants to merge
4
commits into
mozilla:main
Choose a base branch
from
Baptistemontan:into_from_raw
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+74
−1
Open
into/from_parts #97
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get the point of returning pointer / len / capacity separately.
A
from_raw/into_rawwould be reasonable I guess, but that doesn't work for ZSTs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well capacity is indeed optionnal in theory and be retrieved in the allocation, but length is required for ZSTs, we could have a non-zst variant that just gives a pointer. But without the gecko-ffi feature, how do we properly check if it is a singleton or not ? we might get back a pointer that does'nt have a header, and without the capacity we can't know without doubts if there is one or not, heck even with the cap we can't, but since it has no capacity it did'nt allocate so we can just return a newly created one, and length does'nt helps as it could have allocated then cleared. So we do need the trio for reconstruction.
But at the end of the day, it's the same as Vec,
from_partsdo have stronger expectations than the Vec counterpart but the idea is the same: you get back a pointer, a length and a capacity, and you now own the underlying buffer and are responsible for it's memory management.As for a use case, I guess the same ones as
Vec::into_parts, you can create aThinVec, operate on it, then need a way to own the allocation because there is an API that you use that needs it for XYZ reasons, might be for FFI where it expect the pointer of the buffer, but you can't keep theThinVecalive as now it might alias, or keeping it alive for the whole usage might be difficult.