Don't attach plotly in landscapes vignette - #203
Closed
ms609 wants to merge 1 commit into
Closed
Conversation
`library("plotly")` in landscapes.Rmd put `plotly::layout()` on the search
path. Where vignettes are re-built in a shared R session, this masked
`graphics::layout()` in the subsequently built treespace.Rmd, whose
`plot-mapping-5d` chunk failed with
no applicable method for 'layout' applied to an object of
class "c('double', 'numeric')"
Use `plotly::` prefixes instead, and qualify `graphics::layout()` in
treespace.Rmd so the chunk is robust to any future masking.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ms609
marked this pull request as draft
September 2, 2026 09:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the ubuntu-22.04 / R 4.1 vignette build failure in run 33400859706.
library("plotly")inlandscapes.Rmdputplotly::layout()on the search path. Where vignettes are re-built in a shared R session (as on that runner), it maskedgraphics::layout()in the subsequently builttreespace.Rmd, so theplot-mapping-5dchunk died with:landscapes.Rmd: useplotly::plot_ly()/plotly::add_surface()instead of attaching the package.treespace.Rmd: qualifygraphics::layout()so the chunk is robust to any future masking.Rendered output of both vignettes is unchanged.
Note: opened under @ms609 because
ms609-agenthas no write seat on this repository (PR creation returnedResource not accessible by personal access token); the commit itself is attributed toms609-agent.🤖 Generated with Claude Code