Repository navigation
Compose native full-view background rows with shared visibility plans - #148
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare each full-width background row once and compose main/sub layers using shared visibility spans, reducing repeated per-pixel window and enable decisions. Enable the qualified path for Windows x64 NATIVE builds; retain explicit OFF and the separate LLE renderer. Record the build choice in benchmark and replay identity. The framework pin supplies the portable shared planner and its CI.
Five balanced matched pairs on an i5-4670 show median process-CPU reductions of 7.4% custom 4:3, 9.6% 16:9 and 12.6% 32:9; ordinary stock is neutral/inconclusive. These compare against the already optimized current main, not the original campaign baseline. Private row scratch is 18,432 bytes; executable text/read-only growth is 6,732 bytes.
Qualification: existing scalar/native suites, 512 randomized full-color rows, 4,096 shared visibility plans, eight captured view/HUD comparisons, Magic Carpet native/wide/ultrawide/no-shot gates, current-build restore/rewind and fresh-process replay. The promoted default is verified ON and its renderer, all four Magic Carpet, restore/rewind and fresh-process checks pass again. No simulation/serialized-layout change or netplay protocol change; no original Xbox qualification.
Includes a behavior-neutral armor field rename (
hypertohyper_active) to avoid the Windows RPC macro collision exposed by the state harness. Both measured A/B builds include that fix.Owner explicitly requested main integration. Evidence and raw samples: beads-8wg.2.161, coordinating campaign beads-2wy8.1; source contract/results in docs/ROW_RENDER_PLAN.md.