-
Notifications
You must be signed in to change notification settings - Fork 0
Refactored capabilities into info endpoint #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
58c32df
Split health and capabilities endpoints for chat service
m-messer 16e89d1
Fix typo in description for chat info endpoint
m-messer 5c545e0
Split health and capabilities endpoints for evaluate service
m-messer 92593c8
Remove unused `status` field from chat-info example
m-messer c945061
Merge branch 'main' into gh26-refactor-capabilities-to-info
maximiliansoelch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| get: | ||
| summary: Information of the chat service | ||
| operationId: getChatInfo | ||
| description: > | ||
| Returns information and capabilities of the chat service. | ||
| Clients can use this endpoint to discover whether the service supports | ||
| optional features such as user preferences or streaming responses. | ||
| tags: | ||
| - chat | ||
| parameters: | ||
| - $ref: "../shared/parameters/X-Request-Id.yml" | ||
| - $ref: "../shared/parameters/X-Api-Version.yml" | ||
| responses: | ||
| "200": | ||
| description: Chat service is reachable and reporting capabilities. | ||
| headers: | ||
| X-Request-Id: | ||
| description: Request id for tracing this request across services. | ||
| schema: | ||
| type: string | ||
| X-Api-Version: | ||
| description: The API version that was used to serve this response. | ||
| schema: | ||
| type: string | ||
| content: | ||
| application/json: | ||
| schema: | ||
| $ref: "./schemas/ChatInfoResponse.yml" | ||
| examples: | ||
| exampleInfo: | ||
| summary: Example service with capabilities | ||
| value: | ||
| version: "1.0.0" | ||
| capabilities: | ||
| supportsChat: true | ||
| supportsUserPreferences: true | ||
| supportsStreaming: true | ||
| "supportsDataPolicy": "NOT_SUPPORTED" | ||
| supportedLanguages: | ||
| - "en" | ||
| - "de" | ||
| supportedModels: | ||
| - "gpt-4o" | ||
| - "llama-3" | ||
| supportedVersions: | ||
| - "0.1.0" | ||
| "406": | ||
| $ref: "./responses/406-VersionNotSupported.yml" | ||
| "501": | ||
| description: The server does not implement the info endpoint for chat. | ||
| $ref: "./responses/501-NotImplemented.yml" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| type: object | ||
| description: Information and capabilities of the chat service. | ||
| required: | ||
| - capabilities | ||
| properties: | ||
| version: | ||
| type: | ||
| - string | ||
| - "null" | ||
| description: Optional version of the chat service implementation. | ||
| capabilities: | ||
| $ref: "./ChatCapabilities.yml" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| get: | ||
| summary: Information and capabilities of the evaluate service | ||
| operationId: getEvaluateInfo | ||
| description: > | ||
| Returns information and capabilities of the evaluate service. | ||
| Clients can use this endpoint to discover whether the service supports | ||
| optional features such as pre-submission feedback, formative feedback, | ||
| and summative feedback. | ||
| tags: | ||
| - evaluate | ||
| parameters: | ||
| - $ref: "../shared/parameters/X-Request-Id.yml" | ||
| - $ref: "../shared/parameters/X-Api-Version.yml" | ||
| responses: | ||
| "200": | ||
| description: Evaluate service is reachable and reporting capabilities. | ||
| headers: | ||
| X-Request-Id: | ||
| description: Request id for tracing this request across services. | ||
| schema: | ||
| type: string | ||
| X-Api-Version: | ||
| description: The API version that was used to serve this response. | ||
| schema: | ||
| type: string | ||
| content: | ||
| application/json: | ||
| schema: | ||
| $ref: "./schemas/EvaluateInfoResponse.yml" | ||
| examples: | ||
| exampleInfo: | ||
| summary: Example service with capabilities | ||
| value: | ||
| version: "1.0.0" | ||
| capabilities: | ||
| supportsEvaluate: true | ||
| supportsPreSubmissionFeedback: false | ||
| supportsFormativeFeedback: true | ||
| supportsSummativeFeedback: true | ||
| supportsDataPolicy: "PARTIAL" | ||
| supportedArtefactProfiles: | ||
| - type: "TEXT" | ||
| supportedFormats: ["plain", "markdown"] | ||
| - type: "CODE" | ||
| supportedFormats: ["python", "java", "javascript"] | ||
| - type: "MATH" | ||
| supportedFormats: ["latex", "mathml"] | ||
| supportedLanguages: | ||
| - "en" | ||
| - "de" | ||
| supportedVersions: | ||
| - "0.1.0" | ||
| "406": | ||
| $ref: "./responses/406-VersionNotSupported.yml" | ||
| "501": | ||
| description: The server does not implement the info endpoint for evaluate. | ||
| $ref: "./responses/501-NotImplemented.yml" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,7 @@ | ||
| type: object | ||
| description: Health status and capabilities of the evaluate service. | ||
| description: Health status of the evaluate service. | ||
| required: | ||
| - status | ||
| - capabilities | ||
| properties: | ||
| status: | ||
| $ref: "../../shared/enums/HealthStatus.yml" | ||
|
|
@@ -16,12 +15,3 @@ properties: | |
| - string | ||
| - "null" | ||
| description: Optional version of the evaluate service implementation. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here, I would say health to have version |
||
| requirements: | ||
| type: | ||
| - object | ||
| - "null" | ||
| description: Optional requirements clients must satisfy to use this service. | ||
| allOf: | ||
| - $ref: "./EvaluateRequirements.yml" | ||
| capabilities: | ||
| $ref: "./EvaluateCapabilities.yml" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| type: object | ||
| description: Information and capabilities of the evaluate service. | ||
| required: | ||
| - capabilities | ||
| properties: | ||
| version: | ||
| type: | ||
| - string | ||
| - "null" | ||
| description: Optional version of the evaluate service implementation. | ||
| requirements: | ||
| type: | ||
| - object | ||
| - "null" | ||
| description: Optional requirements clients must satisfy to use this service. | ||
| allOf: | ||
| - $ref: "./EvaluateRequirements.yml" | ||
| capabilities: | ||
| $ref: "./EvaluateCapabilities.yml" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't health also have the version?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does have the version on the lines highlighted. Which version do you mean? muEd or the chat function version? Or remove version from info?